[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disab
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disabled |
|
Date: |
Thu, 11 May 2017 09:48:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 11/05/2017 04:56, Peter Xu wrote:
>> @@ -3510,12 +3511,16 @@ static void kvm_update_msi_routes_all(void *private,
>> bool global,
>> int cnt = 0;
>> MSIRouteEntry *entry;
>> MSIMessage msg;
>> + PCIDevice *dev;
>> +
>> /* TODO: explicit route update */
>> QLIST_FOREACH(entry, &msi_route_list, list) {
>> - cnt++;
>
> Oops, I think this line should be kept. It does not affect too much,
> only the trace below. But still, no reason to remove it.
>
> Paolo, would it still possible to touch it up in your queue?
Yup, fixed.
Paolo