[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comme
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag |
Date: |
Mon, 15 May 2017 10:46:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Stefano or Anthony, please review.
Eduardo Habkost <address@hidden> writes:
> xen-backend can be plugged/unplugged dynamically when using the
> Xen accelerator, so keep the user_creatable flag on the device
> class and remove the FIXME comment.
>
> Cc: Juergen Gross <address@hidden>,
> Cc: Peter Maydell <address@hidden>,
> Cc: Thomas Huth <address@hidden>
> Cc: address@hidden
> Cc: Markus Armbruster <address@hidden>,
> Cc: Marcel Apfelbaum <address@hidden>,
> Cc: Laszlo Ersek <address@hidden>
> Acked-by: Juergen Gross <address@hidden>
> Acked-by: Marcel Apfelbaum <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes series v1 -> v2:
> * (New patch added to series)
> ---
> hw/xen/xen_backend.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
> index 67cb4cb9f0..2b91d2d458 100644
> --- a/hw/xen/xen_backend.c
> +++ b/hw/xen/xen_backend.c
> @@ -619,10 +619,7 @@ static void xendev_class_init(ObjectClass *klass, void
> *data)
>
> dc->props = xendev_properties;
> set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> - /*
> - * FIXME: Set only because we are not sure yet if this device
> - * will be outside the q35 sysbus whitelist.
> - */
> + /* xen-backend devices can be plugged/unplugged dynamically */
> dc->user_creatable = true;
> }
- [Qemu-devel] [PATCH RESEND v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 01/21] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag,
Markus Armbruster <=
- [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo, Eduardo Habkost, 2017/05/03
- [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Eduardo Habkost, 2017/05/03
- Re: [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE, Markus Armbruster, 2017/05/15
[Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag, Eduardo Habkost, 2017/05/03