[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine types |
Date: |
Mon, 15 May 2017 14:19:20 +0200 |
On Mon, 15 May 2017 05:13:34 -0700 (PDT)
address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine
> types
> Message-id: address@hidden
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> - [tag update] patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 3c3824a spapr: fix migration of ICP objects from/to older QEMU
> 280164f spapr-cpu-core: release ICP object when realization fails
> 5bc72eb spapr: sanitize error handling in spapr_ics_create()
> fa15d00 spapr: fix error reporting in xics_system_init()
> ecbe234 spapr: fix error path of required kernel-irqchip
> b7cf73d ppc/xics: simplify prototype of xics_spapr_init()
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/6: ppc/xics: simplify prototype of xics_spapr_init()...
> Checking PATCH 2/6: spapr: fix error path of required kernel-irqchip...
> Checking PATCH 3/6: spapr: fix error reporting in xics_system_init()...
> Checking PATCH 4/6: spapr: sanitize error handling in spapr_ics_create()...
> Checking PATCH 5/6: spapr-cpu-core: release ICP object when realization
> fails...
> Checking PATCH 6/6: spapr: fix migration of ICP objects from/to older QEMU...
> ERROR: "foo* bar" should be "foo *bar"
> #50: FILE: hw/ppc/spapr.c:167:
> + void* obj = &spapr->legacy_icps[i];
>
Oops, I'll fix that.
> total: 1 errors, 0 warnings, 122 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden
pgpeDOyURYI6f.pgp
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 5/6] spapr-cpu-core: release ICP object when realization fails, (continued)
Re: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine types, no-reply, 2017/05/15
- Re: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine types,
Greg Kurz <=