[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix N
From: |
Kamil Rytarowski |
Subject: |
Re: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build |
Date: |
Mon, 15 May 2017 15:57:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; NetBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 15.05.2017 15:57, Eric Blake wrote:
> On 05/13/2017 05:04 PM, Philippe Mathieu-Daudé wrote:
>> Hi Kamil,
>>
>> I think it is safer to add it in disas/libvixl/Makefile.objs where
>> QEMU_CFLAGS are tuned for libvixl.
>> This way you don't need to modify upstream libvixl.
>>
>
> Ah, right. disas/libvixl is one of the directories exempt from our
> normal rules of including osdep.h first (otherwise I would have said
> that including stdint.h first should be the job of osdep.h).
>
> But indeed, that's because we are trying to leave libvixl as untouched
> as possible, so if there IS a solution that can be done through
> makefiles rather than direct file editing, it is worth considering.
>
http://lists.nongnu.org/archive/html/qemu-devel/2017-05/msg03321.html
signature.asc
Description: OpenPGP digital signature