[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause throug
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay |
Date: |
Tue, 16 May 2017 10:43:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> With the recent addition of ShutdownCause, we want to be able to pass
> a cause through any shutdown request, and then faithfully replay that
> cause when later replaying the same sequence. The easiest way is to
> expand the reply event mechanism to track a series of values for
> EVENT_SHUTDOWN, one corresponding to each value of ShutdownCause.
>
> We are free to change the replay stream as needed, since there are
> already no guarantees about being able to use a replay stream by
> any other version of qemu than the one that generated it.
>
> The cause is not actually fed back until the next patch changes the
> signature for requesting a shutdown; a TODO marks that upcoming change.
>
> Yes, this uses the gcc/clang extension of a ranged case label,
> but this is not the first time we've used non-C99 constructs.
Not even *this* construct, as git-grep shows.
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Pavel Dovgalyuk <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 1/5] shutdown: Simplify shutdown_signal, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay, Eric Blake, 2017/05/15
- Re: [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay,
Markus Armbruster <=
- [Qemu-devel] [PATCH v9 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events, Eric Blake, 2017/05/15
- [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET, Eric Blake, 2017/05/15
- Re: [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN, Markus Armbruster, 2017/05/16