[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Make migration/ram.c target independent
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Make migration/ram.c target independent |
Date: |
Thu, 18 May 2017 18:31:00 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, May 17, 2017 at 06:08:02PM +0200, Juan Quintela wrote:
> Hi
>
> Only reason that ram.c is compiled by target is because it use
> TARGET_PAGE_BITS. As we already have a function to export
> TARGET_PAGE_SIZE, do the same.
> After this, we can make it target independent.
>
> Please, review.
>
> Later, Juan.
>
>
>
>
> Juan Quintela (2):
> exec: Create include for target_page_size()
> migration: Make savevm.c target independent
>
> Makefile.target | 2 +-
> exec.c | 10 ++++++++++
> include/exec/target_page.h | 22 ++++++++++++++++++++++
> include/sysemu/sysemu.h | 1 -
> migration/Makefile.objs | 2 +-
> migration/migration.c | 1 +
> migration/postcopy-ram.c | 1 +
> migration/savevm.c | 15 ++++++++-------
> 8 files changed, 44 insertions(+), 10 deletions(-)
> create mode 100644 include/exec/target_page.h
Though I am not 100% sure of the relationship between TARGET_PAGE_*,
qemu_target_page_*(), and exec/poison.h, but at least we already have
qemu_target_page_size(), and this patch moves savevm.c out of
arch-dependent list, which does make sense. So:
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu