[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19 |
Date: |
Fri, 19 May 2017 18:09:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 19/05/2017 17:51, Stefan Hajnoczi wrote:
>> This series seems to have some coding style problems. See output below for
>> more information:
> Yikes, on second thought I've dropped the pull request for now.
>
> Please look at these coding style violations.
These are just a sample program, so I didn't really care much. But
these three aren't:
Checking PATCH 17/20: vhost-user-scsi: Introduce vhost-user-scsi host
device...
ERROR: do not use C99 // comments
#216: FILE: hw/scsi/vhost-user-scsi.c:145:
+ // Turn on predefined features supported by this device
ERROR: do not use C99 // comments
#261: FILE: hw/scsi/vhost-user-scsi.c:190:
+ // Add the bootindex property for this object
ERROR: do not use C99 // comments
#265: FILE: hw/scsi/vhost-user-scsi.c:194:
+ // Set boot index according the the device config
total: 3 errors, 0 warnings, 382 lines checked
so I guess I'll fix the sample program too.
Paolo
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 11/20] nbd: read_sync and friends: return 0 on success, (continued)
- [Qemu-devel] [PULL 11/20] nbd: read_sync and friends: return 0 on success, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 16/20] virtio-scsi: Unset hotplug handler when unrealize, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 13/20] nbd: add errp to read_sync, write_sync and drop_sync, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 15/20] exec: simplify phys_page_find() params, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 17/20] vhost-user-scsi: Introduce vhost-user-scsi host device, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 19/20] target/i386: enable A20 automatically in system management mode, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 20/20] target/i386: use multiple CPU AddressSpaces, Paolo Bonzini, 2017/05/19
- [Qemu-devel] [PULL 18/20] vhost-user-scsi: Introduce a vhost-user-scsi sample application, Paolo Bonzini, 2017/05/19
- Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19, no-reply, 2017/05/19
- Re: [Qemu-devel] [PULL 00/20] Misc patches for 2017-05-19, Stefan Hajnoczi, 2017/05/19