[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencie
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow |
Date: |
Mon, 22 May 2017 14:37:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/19/2017 04:34 AM, Anton Nefedov wrote:
> Avoid complicated nested conditions; return or continue asap instead.
> The logic is not changed.
>
> Signed-off-by: Anton Nefedov <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> ---
> block/qcow2-cluster.c | 45 ++++++++++++++++++++++-----------------------
> 1 file changed, 22 insertions(+), 23 deletions(-)
>
>
> - /* Stop if already an l2meta exists. After yielding, it wouldn't
As long as you're touching this,
> - }
> + /* Stop if already an l2meta exists. After yielding, it wouldn't
fix the grammar: s/already an l2meta/an l2meta already/
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v1 03/13] qcow2: do not COW the empty areas, (continued)
- [Qemu-devel] [PATCH v1 05/13] qcow2: set inactive flag, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 04/13] qcow2: preallocation at image expand, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 06/13] qcow2: truncate preallocated space, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 08/13] qcow2: handle_prealloc(): find out if area zeroed by earlier preallocation, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 09/13] qcow2: fix misleading comment about L2 linking, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 07/13] qcow2: check space leak at the end of the image, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow, Anton Nefedov, 2017/05/19
- Re: [Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow,
Eric Blake <=
- [Qemu-devel] [PATCH v1 13/13] iotest 046: test simultaneous cluster write error case, Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 10/13] qcow2-cluster: slightly refactor handle_dependencies(), Anton Nefedov, 2017/05/19
- [Qemu-devel] [PATCH v1 12/13] qcow2: allow concurrent unaligned writes to the same clusters, Anton Nefedov, 2017/05/19
- Re: [Qemu-devel] [PATCH v1 00/13] qcow2: space preallocation and COW improvements, Eric Blake, 2017/05/23