[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 27/31] target/s390x: Use unwind data for helper_
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 27/31] target/s390x: Use unwind data for helper_tprot |
Date: |
Tue, 23 May 2017 12:14:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 23.05.2017 05:03, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/mem_helper.c | 1 -
> target/s390x/translate.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
> index a874f8a..7f22bf0 100644
> --- a/target/s390x/mem_helper.c
> +++ b/target/s390x/mem_helper.c
> @@ -943,7 +943,6 @@ uint32_t HELPER(testblock)(CPUS390XState *env, uint64_t
> real_addr)
> uint32_t HELPER(tprot)(uint64_t a1, uint64_t a2)
> {
> /* XXX implement */
> -
Unnecessary white space change ;-)
> return 0;
> }
>
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index 694e099..282fa27 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -4054,7 +4054,6 @@ static ExitStatus op_testblock(DisasContext *s,
> DisasOps *o)
>
> static ExitStatus op_tprot(DisasContext *s, DisasOps *o)
> {
> - potential_page_fault(s);
> gen_helper_tprot(cc_op, o->addr1, o->in2);
> set_cc_static(s);
> return NO_EXIT;
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 23/31] target/s390x: Use unwind data for helper_lctlg, (continued)
- [Qemu-devel] [PATCH 23/31] target/s390x: Use unwind data for helper_lctlg, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 25/31] target/s390x: Use unwind data for helper_stctl, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 26/31] target/s390x: Use unwind data for helper_testblock, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 27/31] target/s390x: Use unwind data for helper_tprot, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 29/31] target/s390x: Use atomic operations for COMPARE SWAP PURGE, Richard Henderson, 2017/05/22
- [Qemu-devel] [PATCH 30/31] target/s390x: Implement CSPG, Richard Henderson, 2017/05/22
[Qemu-devel] [PATCH 31/31] target/s390x: Use unwind data for helper_mvcs/mvcp, Richard Henderson, 2017/05/22