[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParam
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams |
Date: |
Wed, 24 May 2017 14:48:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Juan Quintela <address@hidden> writes:
>
>> We have change in the previous patch to use migration capabilities for
>> it. Notice that we continue using the old command line flags from
>> migrate command from the time being. Remove the set_params method as
>> now it is empty.
>>
>> For savevm, one can't do a:
>>
>> savevm -b/-i foo
>
> Yes (savem has no such options).
>
>> but now one can do:
>>
>> migrate_set_capability block on
>> savevm foo
>>
>> And we can't use block migration. We could disable block capability
>> unconditionally, but it would not be much better.
>
> This leaves me confused: what does the example do? Reading ahead...
> looks like it fails with "Block migration and snapshots are
> incompatible". What are you trying to say here?
I think I now get what you're trying to say, but only because I've
picked up enough context. Let me try to rephrase:
migration: Use new configuration instead of old MigrationParams
The previous commit introduced a MigrationCapability and a
MigrationParameter for block migration. Use them instead of the old
MigrationParams.
Take care to reject attempts to combine block migration with
snapshots, e.g. like this:
migrate_set_capability block on
savevm foo
>> Signed-off-by: Juan Quintela <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Patch looks good to me.
Preferably with a commit message I can still understand three weeks from
now:
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH 0/5] Remove old MigrationParams, Juan Quintela, 2017/05/18
- [Qemu-devel] [PATCH 1/5] hmp: Use visitor api for hmp_migrate_set_parameter(), Juan Quintela, 2017/05/18
- [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams, Juan Quintela, 2017/05/18
- [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable, Juan Quintela, 2017/05/18
- [Qemu-devel] [PATCH 2/5] migration: Create block capability, Juan Quintela, 2017/05/18
- [Qemu-devel] [PATCH 4/5] migration: Remove old MigrationParams, Juan Quintela, 2017/05/18
- Re: [Qemu-devel] [PATCH 0/5] Remove old MigrationParams, Dr. David Alan Gilbert, 2017/05/18