[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/18] block: access quiesce_counter with atomic ops
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 02/18] block: access quiesce_counter with atomic ops |
Date: |
Thu, 25 May 2017 18:32:09 +0200 |
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/io.c | 4 ++--
include/block/block_int.h | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/io.c b/block/io.c
index 80a3a8c..7d31946 100644
--- a/block/io.c
+++ b/block/io.c
@@ -240,7 +240,7 @@ void bdrv_drained_begin(BlockDriverState *bs)
return;
}
- if (!bs->quiesce_counter++) {
+ if (atomic_fetch_inc(&bs->quiesce_counter) == 0) {
aio_disable_external(bdrv_get_aio_context(bs));
bdrv_parent_drained_begin(bs);
}
@@ -251,7 +251,7 @@ void bdrv_drained_begin(BlockDriverState *bs)
void bdrv_drained_end(BlockDriverState *bs)
{
assert(bs->quiesce_counter > 0);
- if (--bs->quiesce_counter > 0) {
+ if (atomic_fetch_dec(&bs->quiesce_counter) > 1) {
return;
}
diff --git a/include/block/block_int.h b/include/block/block_int.h
index c71492a..4af44df 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -637,6 +637,7 @@ struct BlockDriverState {
/* do we need to tell the quest if we have a volatile write cache? */
int enable_write_cache;
+ /* Accessed with atomic ops. */
int quiesce_counter;
};
--
1.8.3.1
- [Qemu-devel] [PATCH v3 00/18] Block layer thread safety, part 1, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 01/18] block: access copy_on_read with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 04/18] block: access serialising_in_flight with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 02/18] block: access quiesce_counter with atomic ops,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/18] block: access wakeup with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 03/18] block: access io_limits_disabled with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 06/18] block: access io_plugged with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 07/18] throttle-groups: only start one coroutine from drained_begin, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 08/18] throttle-groups: do not use qemu_co_enter_next, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 11/18] block: use Stat64 for wr_highest_offset, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 10/18] util: add stats64 module, Paolo Bonzini, 2017/05/25
- [Qemu-devel] [PATCH 12/18] block: access write_gen with atomics, Paolo Bonzini, 2017/05/25