[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] pci: Set err to errp directly rather than th
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] pci: Set err to errp directly rather than through error_porpagate() |
Date: |
Fri, 26 May 2017 08:33:01 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/26/2017 06:58 AM, Mao Zhongyi wrote:
In the subject: s/porpagate/propagate/
> ioh3420_interrupts_init() and its callers rp_realize() fill error
> message to local_err, then propagate it to errp by error_porpagate(),
and again
> which's not necessary. So eliminate it and pass errp directly instead
s/which's/which is/ (English does not have the abbreviation which's)
> of local_err. Of course, error_propagate() also has been removed.
>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
> v2:
> * Drop the part of wrong handling that ignored the fact that if
> pci_qdev_realize()'s caller pass errp = NULL.
>
The code portion is fine, so with the commit message fixed (which a
maintainer might do without needing you to send a v3),
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature