[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 25/26] target/s390x: implement TRANSLATE ONE/TWO TO ONE/TWO |
Date: |
Mon, 29 May 2017 13:17:18 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 2017-05-26 10:10, Richard Henderson wrote:
> On 05/25/2017 02:05 PM, Aurelien Jarno wrote:
> > +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_t r2,
> > + uint32_t sizes)
> > +{
> > + uintptr_t ra = GETPC();
> > + int dsize = (sizes & 1) ? 1 : 2;
> > + int ssize = (sizes & 2) ? 1 : 2;
> > + uint16_t tst = env->regs[0] & ((1 << (8 * dsize)) - 1);
>
> I think you should pass in tst as an argument. That way you can pass in an
> out-of-band value when we implement ETF2 and test field M3 bit 3.
I don't mind passing r0 as an argument. That said if we want to pass tst
or bundle the M3 field, it means we need to use TCG instructions to do
so. I am not sure it brings a lot compare to doing so in the helper
side.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH 15/26] target/s390x: fix COMPARE LOGICAL LONG EXTENDED, (continued)
[Qemu-devel] [PATCH 23/26] target/s390x: implement UNPACK UNICODE, Aurelien Jarno, 2017/05/25
[Qemu-devel] [PATCH 02/26] target/s390x: make IPTE SMP aware, Aurelien Jarno, 2017/05/25
[Qemu-devel] [PATCH 10/26] target/s390x: implement MOVE WITH OFFSET, Aurelien Jarno, 2017/05/25