Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> On Tue, May 23, 2017 at 04:23:08PM +0200, Markus Armbruster wrote:
>> Eduardo Habkost <address@hidden> writes:
>> 
>> > Keep the Popen object around to we can query its exit code later.
>> >
>> > To keep the existing 'self._popen is None' checks working, add a
>> > is_running() method, that will check if the process is still running.
>> >
>> > Signed-off-by: Eduardo Habkost <address@hidden>
>> 
>> Looks harmless enough.  Have you tested the scripts using this module
>> still work?
>
> Now I did. :)
>
> I see only two users of qemu.py and qtest.py:
>
>   tests/migration/guestperf/engine.py:import qemu
>   tests/qemu-iotests/iotests.py:import qtest
>
> I just tested both using:
>
>   $ make check-tests/qemu-iotests-quick.sh
>   $ make tests/migration/initrd-stress.img PTHREAD_LIB=-pthread
>   $ ./tests/migration/guestperf.py > /tmp/guestperf.json
>
> and they seem to be working.

Thanks!

> (It looks like there's no Makefile rule to run guestperf.py)
>
> BTW, it seems to be impossible to build initrd-stress.img on a out-of-tree
> build.  I had to run ./configure inside the source tree to be able to run
> guestperf.py.

I consider that a bug.  But it's clearly not one you need to fix to get
your series accepted.