[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] hostmem-file: add an attribute 'align' to s
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment |
|
Date: |
Tue, 30 May 2017 10:16:24 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, May 26, 2017 at 10:24:38AM +0800, Haozhong Zhang wrote:
> file_ram_alloc() currently maps the backend file via mmap to a virtual
> address aligned to the value returned by qemu_fd_getpagesize(). When a
> DAX device (e.g. /dev/dax0.0) is used as the backend file, its kernel
> mmap implementation may require an alignment larger than what
> qemu_fd_get_pagesize() returns (e.g. 2MB vs. 4KB), and mmap may fail.
>
> This commit adds an attribute 'align' to hostmem-file, so that users
> can specify a proper alignment that satisfies the kernel requirement.
>
> If 'align' is not specified or is 0, the value returned by
> qemu_fd_get_pagesize() will be used as before.
How are users supposed to determine alignment requirements?
signature.asc
Description: PGP signature