[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 02/45] qapi: Document visit_type_any() issues wit
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v2 02/45] qapi: Document visit_type_any() issues with keyval input |
Date: |
Wed, 31 May 2017 17:56:26 +0400 |
From: Markus Armbruster <address@hidden>
It's already documented in keyval.c (commit 0ee9ae7), but visitor.h
can use a note, too.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
include/qapi/visitor.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index b0e233df76..4721c39ae3 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -607,6 +607,10 @@ void visit_type_number(Visitor *v, const char *name,
double *obj,
* @obj must be non-NULL. Input visitors set address@hidden to the value;
* other visitors will leave address@hidden unchanged. address@hidden must be
non-NULL
* for output visitors.
+ *
+ * Note that some kinds of input can't express arbitrary QObject.
+ * E.g. the visitor returned by qobject_input_visitor_new_keyval()
+ * can't create numbers or booleans, only strings.
*/
void visit_type_any(Visitor *v, const char *name, QObject **obj, Error **errp);
--
2.13.0.91.g00982b8dd
- [Qemu-devel] [PATCH v2 00/45] qobject/qapi: add uint type, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 01/45] qobject-input-visitor: Reject non-finite numbers with keyval, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 02/45] qapi: Document visit_type_any() issues with keyval input,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v2 03/45] tests/qapi-schema: Avoid 'str' in alternate test cases, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 04/45] qapi: Reject alternates that can't work with keyval_parse(), Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 05/45] qdev: remove PropertyInfo.qtype field, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 06/45] object: fix potential leak in getters, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 07/45] tests: remove alt num-int cases, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 08/45] tests: add more int/number ranges checks, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 10/45] qapi: Remove visit_start_alternate() parameter promote_int, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 09/45] qapi: merge QInt and QFloat in QNum, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 11/45] tests: remove /qnum/destroy test, Marc-André Lureau, 2017/05/31
- [Qemu-devel] [PATCH v2 12/45] qnum: add uint type, Marc-André Lureau, 2017/05/31