[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/15] chardev patches
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PULL 00/15] chardev patches |
Date: |
Mon, 05 Jun 2017 10:50:16 +0000 |
Hi
On Mon, Jun 5, 2017 at 2:15 PM Peter Maydell <address@hidden>
wrote:
> On 2 June 2017 at 20:15, Marc-André Lureau <address@hidden>
> wrote:
> > Sorry, git-publish printed an error on invalid remote, but keep going. I
> > should fix it. Here is the new pull request:
> >
> > The following changes since commit
> 43771d5d92312504305c19abe29ec5bfabd55f01:
> >
> > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2017-05-31'
> > into staging (2017-06-01 16:39:16 +0100)
> >
> > are available in the git repository at:
> >
> > https://github.com/elmarco/qemu.git tags/chrfe-pull-request
> >
> >
> > for you to fetch changes up to 6b10e573d15ef82dbc5c5b3726028e6642e134f6:
> >
> > char: move char devices to chardev/ (2017-06-02 11:33:53 +0400)
>
> Thanks, applied to master.
>
> You forgot to add your signed-off-by line as submaintainer to the
> commit from Philippe -- since it's a two line patch I didn't think it
>
Oh I didn't know I have to add my sign-off too, I thought reviewed-by was
enough. Ok
> was worth pushing back for a respin, but it's worth adding an
> automated "check all commits have my signoff" to your "make a pull
> request" script I think.
>
> For example, see lines 98--109 in my script:
>
> https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/make-pullreq
Ok, I am using git-publish (btw, Stefan merged a fix to avoid the previous
pullreq issue), and it seems -s will add missing sign-off during
format-patch.
Thanks,
>
>
> thanks
> -- PMM
>
--
Marc-André Lureau
- [Qemu-devel] [PULL 10/15] be-hci: use backend functions, (continued)
- [Qemu-devel] [PULL 10/15] be-hci: use backend functions, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 11/15] char: generalize qemu_chr_write_all(), Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 12/15] char: move CharBackend handling in char-fe unit, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 13/15] char: rename functions that are not part of fe, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 14/15] char: make chr_fe_deinit() optionaly delete backend, Marc-André Lureau, 2017/06/02
- [Qemu-devel] [PULL 15/15] char: move char devices to chardev/, Marc-André Lureau, 2017/06/02
- Re: [Qemu-devel] [PULL 00/15] chardev patches, Peter Maydell, 2017/06/02