[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure |
Date: |
Tue, 6 Jun 2017 10:11:56 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Jun 05, 2017 at 09:24:38AM +0200, Andrew Jones wrote:
> On Fri, Jun 02, 2017 at 09:46:35AM +0000, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Jun 1, 2017 at 10:19 PM Eric Blake <address@hidden> wrote:
> >
> > > On 06/01/2017 01:06 PM, Laszlo Ersek wrote:
> > > > On 06/01/17 15:03, Marc-André Lureau wrote:
> > > >> One way or another, the guest could communicate various dump info (via
> > > >> guest agent or vmcoreinfo device) and populate that structure. It can
> > > >> then be used to augment the dump with various details, as done in the
> > > >> following patch.
> > > >>
> > > >> Signed-off-by: Marc-André Lureau <address@hidden>
> > > >> ---
> > > >> include/sysemu/dump-info.h | 18 ++++++++++++++++++
> > > >> dump.c | 3 +++
> > > >> 2 files changed, 21 insertions(+)
> > > >> create mode 100644 include/sysemu/dump-info.h
> > > >>
> > > >> diff --git a/include/sysemu/dump-info.h b/include/sysemu/dump-info.h
> > > >> new file mode 100644
> > > >> index 0000000000..d2378e15e2
> > > >> --- /dev/null
> > > >> +++ b/include/sysemu/dump-info.h
> > > >> @@ -0,0 +1,18 @@
> > > >> +#ifndef DUMP_INFO_H
> > > >> +#define DUMP_INFO_H
> > >
> > > >>
> > > >
> > > > Can you please spell out, in the commit message, the reason for
> > > > introducing a new header file? (I suspect your reason, but it should be
> > > > documented explicitly.)
> > >
> > > Also, should you have a copyright header in the new file? And does
> > > MAINTAINERS cover it?
> > >
> >
> > None of the dump support is covered. Based on commit history, I can suggest
> > Wen Congyang, as original author.
> > Sadly, Qiao Nuohan cannot be reached with his mail today (anyone knows if
> > he is still contributing?). Laszlo has done significant changes and reviews
> > too. I can also propose myself to help with reviews.
> >
> > Wen or Laszla, do you want to be the main maintainer?
>
> What about Peter Xu (CC'ed)? He'll have to state whether he has time and
> interest, but I see he's contributed quite a bit to dump.c.
I believe those were the first commits of mine when working on
detached dump, after that I didn't really work on it anymore. So I
guess I may not be the best candidate.
Also, I admit my bandwidth is limited as well recently. Thanks Drew
for mentioning me anyway. :-)
--
Peter Xu
- [Qemu-devel] [PATCH v2 0/4] dump: add vmcoreinfo note, Marc-André Lureau, 2017/06/01
- [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Marc-André Lureau, 2017/06/01
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Laszlo Ersek, 2017/06/01
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Eric Blake, 2017/06/01
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Marc-André Lureau, 2017/06/02
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Marc-André Lureau, 2017/06/02
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Laszlo Ersek, 2017/06/02
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Zhang Chen, 2017/06/04
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Laszlo Ersek, 2017/06/06
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure, Andrew Jones, 2017/06/05
- Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure,
Peter Xu <=
[Qemu-devel] [PATCH v2 2/4] dump: add vmcoreinfo ELF note, Marc-André Lureau, 2017/06/01
Re: [Qemu-devel] [PATCH v2 2/4] dump: add vmcoreinfo ELF note, Andrew Jones, 2017/06/05
[Qemu-devel] [PATCH v2 3/4] kdump: add vmcoreinfo, Marc-André Lureau, 2017/06/01
[Qemu-devel] [PATCH v2 4/4] scripts/dump-guest-memory.py: add vmcoreinfo, Marc-André Lureau, 2017/06/01
Re: [Qemu-devel] [PATCH v2 0/4] dump: add vmcoreinfo note, no-reply, 2017/06/01