Re: [Qemu-devel] [RISU PATCH v4 05/10] risu: paramterise send/receive functions

[Peter Maydell]

On 2 June 2017 at 17:08, Alex Bennée <address@hidden> wrote:
> This is a precursor to record/playback support. Instead of passing the
> socket fd we now pass helper functions for reading/writing and
> responding. This will allow us to do the rest of the record/playback
> cleanly outside of the main worker function.
>
> Signed-off-by: Alex Bennée <address@hidden>

> -        } else if (!reginfo_is_eq(&master_ri, &apprentice_ri)) {
> +         } else if (!reginfo_is_eq(&master_ri, &apprentice_ri)) {
>              /* register mismatch */
>              resp = 2;
> -
> -        } else if (op == OP_TESTEND) {
> +         } else if (op == OP_TESTEND) {
>              resp = 1;
> -        }

[etc]

If you're going to fix the indent can you put that in
its own patch, please? Much easier to review that way.

thanks
-- PMM