Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure

[Laszlo Ersek]

On 06/04/17 17:56, Zhang Chen wrote:
> 
> 
> On 06/03/2017 06:49 AM, Laszlo Ersek wrote:
>> On 06/02/17 11:55, Marc-André Lureau wrote:
>>> Hi
>>>
>>> On Fri, Jun 2, 2017 at 1:46 PM Marc-André Lureau
>>> <address@hidden>
>>> wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, Jun 1, 2017 at 10:19 PM Eric Blake <address@hidden> wrote:
>>>>
>>>>> On 06/01/2017 01:06 PM, Laszlo Ersek wrote:
>>>>>> On 06/01/17 15:03, Marc-André Lureau wrote:
>>>>>>> One way or another, the guest could communicate various dump info
>>>>>>> (via
>>>>>>> guest agent or vmcoreinfo device) and populate that structure. It
>>>>>>> can
>>>>>>> then be used to augment the dump with various details, as done in
>>>>>>> the
>>>>>>> following patch.
>>>>>>>
>>>>>>> Signed-off-by: Marc-André Lureau <address@hidden>
>>>>>>> ---
>>>>>>>   include/sysemu/dump-info.h | 18 ++++++++++++++++++
>>>>>>>   dump.c                     |  3 +++
>>>>>>>   2 files changed, 21 insertions(+)
>>>>>>>   create mode 100644 include/sysemu/dump-info.h
>>>>>>>
>>>>>>> diff --git a/include/sysemu/dump-info.h b/include/sysemu/dump-info.h
>>>>>>> new file mode 100644
>>>>>>> index 0000000000..d2378e15e2
>>>>>>> --- /dev/null
>>>>>>> +++ b/include/sysemu/dump-info.h
>>>>>>> @@ -0,0 +1,18 @@
>>>>>>> +#ifndef DUMP_INFO_H
>>>>>>> +#define DUMP_INFO_H
>>>>>> Can you please spell out, in the commit message, the reason for
>>>>>> introducing a new header file? (I suspect your reason, but it
>>>>>> should be
>>>>>> documented explicitly.)
>>>>> Also, should you have a copyright header in the new file?  And does
>>>>> MAINTAINERS cover it?
>>>>>
>>>> None of the dump support is covered. Based on commit history, I can
>>>> suggest Wen Congyang, as original author.
>>>> Sadly, Qiao Nuohan cannot be reached with his mail today (anyone
>>>> knows if
>>>> he is still contributing?). Laszlo has done significant changes and
>>>> reviews
>>>> too. I can also propose myself to help with reviews.
>>>>
>>>> Wen or Laszla, do you want to be the main maintainer?
> 
> I can cc Qiao Nuohan<address@hidden>...

That would be great, thanks!
Laszlo

> 
> Thanks
> Zhang Chen
> 
>>>>
>>> (sorry for the typo)
>>>
>>> or rather "Supported" ("Someone is actually paid to look after this"
>>> according to MAINTAINERS)
>>>
>> Thanks, but I don't wish to have an official responsibility for this
>> feature. My current responsibilities are more than enough to keep me
>> busy.
>>
>> If you'd like to volunteer for maintaining the dump stuff, you have my
>> blessing of course (whatever weight that might carry).
>>
>> Thanks
>> Laszlo
>>
>>
>>
>>
>