[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 20/70] target/s390x: Use unwind data for helper_un
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL v2 20/70] target/s390x: Use unwind data for helper_unpk |
Date: |
Tue, 6 Jun 2017 17:30:29 -0700 |
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/s390x/mem_helper.c | 9 +++++----
target/s390x/translate.c | 1 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index d4ee364..0701e10 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -679,6 +679,7 @@ uint64_t HELPER(cksm)(CPUS390XState *env, uint64_t r1,
void HELPER(unpk)(CPUS390XState *env, uint32_t len, uint64_t dest,
uint64_t src)
{
+ uintptr_t ra = GETPC();
int len_dest = len >> 4;
int len_src = len & 0xf;
uint8_t b;
@@ -688,8 +689,8 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len,
uint64_t dest,
src += len_src;
/* last byte is special, it only flips the nibbles */
- b = cpu_ldub_data(env, src);
- cpu_stb_data(env, dest, (b << 4) | (b >> 4));
+ b = cpu_ldub_data_ra(env, src, ra);
+ cpu_stb_data_ra(env, dest, (b << 4) | (b >> 4), ra);
src--;
len_src--;
@@ -699,7 +700,7 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len,
uint64_t dest,
uint8_t cur_byte = 0;
if (len_src > 0) {
- cur_byte = cpu_ldub_data(env, src);
+ cur_byte = cpu_ldub_data_ra(env, src, ra);
}
len_dest--;
@@ -718,7 +719,7 @@ void HELPER(unpk)(CPUS390XState *env, uint32_t len,
uint64_t dest,
/* zone bits */
cur_byte |= 0xf0;
- cpu_stb_data(env, dest, cur_byte);
+ cpu_stb_data_ra(env, dest, cur_byte, ra);
}
}
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 40965ea..10262f5 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -4099,7 +4099,6 @@ static ExitStatus op_trt(DisasContext *s, DisasOps *o)
static ExitStatus op_unpk(DisasContext *s, DisasOps *o)
{
TCGv_i32 l = tcg_const_i32(get_field(s->fields, l1));
- potential_page_fault(s);
gen_helper_unpk(cpu_env, l, o->addr1, o->in2);
tcg_temp_free_i32(l);
return NO_EXIT;
--
2.9.4
- [Qemu-devel] [PULL v2 10/70] target/s390x: Use unwind data for helper_srst, (continued)
- [Qemu-devel] [PULL v2 10/70] target/s390x: Use unwind data for helper_srst, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 11/70] target/s390x: Use unwind data for helper_clst, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 12/70] target/s390x: Use unwind data for helper_mvpg, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 13/70] target/s390x: Use unwind data for helper_mvst, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 14/70] target/s390x: Use unwind data for helper_lam, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 15/70] target/s390x: Use unwind data for helper_stam, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 16/70] target/s390x: Use unwind data for helper_mvcl, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 17/70] target/s390x: Use unwind data for helper_mvcle, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 19/70] target/s390x: Use unwind data for helper_cksm, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 18/70] target/s390x: Use unwind data for helper_clcle, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 20/70] target/s390x: Use unwind data for helper_unpk,
Richard Henderson <=
- [Qemu-devel] [PULL v2 21/70] target/s390x: Use unwind data for helper_tr, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 22/70] target/s390x: Use unwind data for helper_tre, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 23/70] target/s390x: Use unwind data for helper_trt, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 24/70] target/s390x: Use unwind data for helper_lctlg, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 25/70] target/s390x: Use unwind data for helper_lctl, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 26/70] target/s390x: Use unwind data for helper_stctl, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 27/70] target/s390x: Use unwind data for helper_testblock, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 28/70] target/s390x: Use unwind data for helper_tprot, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 30/70] target/s390x: Use unwind data for helper_mvcs/mvcp, Richard Henderson, 2017/06/06
- [Qemu-devel] [PULL v2 32/70] target/s390x: Fix EXECUTE with R1==0, Richard Henderson, 2017/06/06