[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 04/43] tests: add more int/number ranges checks
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 04/43] tests: add more int/number ranges checks |
Date: |
Wed, 7 Jun 2017 20:35:56 +0400 |
Signed-off-by: Marc-André Lureau <address@hidden>
---
tests/test-qobject-input-visitor.c | 38 +++++++++++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/tests/test-qobject-input-visitor.c
b/tests/test-qobject-input-visitor.c
index 83d663d11d..3a6ce2226c 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -107,6 +107,7 @@ static void test_visitor_in_int(TestInputVisitorData *data,
const void *unused)
{
int64_t res = 0;
+ double dbl;
int value = -42;
Visitor *v;
@@ -114,6 +115,9 @@ static void test_visitor_in_int(TestInputVisitorData *data,
visit_type_int(v, NULL, &res, &error_abort);
g_assert_cmpint(res, ==, value);
+
+ visit_type_number(v, NULL, &dbl, &error_abort);
+ g_assert_cmpfloat(dbl, ==, -42.0);
}
static void test_visitor_in_uint(TestInputVisitorData *data,
@@ -121,6 +125,8 @@ static void test_visitor_in_uint(TestInputVisitorData *data,
{
Error *err = NULL;
uint64_t res = 0;
+ int64_t i64;
+ double dbl;
int value = 42;
Visitor *v;
@@ -129,8 +135,13 @@ static void test_visitor_in_uint(TestInputVisitorData
*data,
visit_type_uint64(v, NULL, &res, &error_abort);
g_assert_cmpuint(res, ==, (uint64_t)value);
- /* BUG: value between INT64_MIN and -1 accepted modulo 2^64 */
+ visit_type_int(v, NULL, &i64, &error_abort);
+ g_assert_cmpint(i64, ==, value);
+
+ visit_type_number(v, NULL, &dbl, &error_abort);
+ g_assert_cmpfloat(dbl, ==, value);
+ /* BUG: value between INT64_MIN and -1 accepted modulo 2^64 */
v = visitor_input_test_init(data, "%d", -value);
visit_type_uint64(v, NULL, &res, &error_abort);
@@ -142,6 +153,8 @@ static void test_visitor_in_uint(TestInputVisitorData *data,
visit_type_uint64(v, NULL, &res, &err);
error_free_or_abort(&err);
+
+ visit_type_number(v, NULL, &dbl, &error_abort);
}
static void test_visitor_in_int_overflow(TestInputVisitorData *data,
@@ -260,6 +273,27 @@ static void test_visitor_in_number(TestInputVisitorData
*data,
g_assert_cmpfloat(res, ==, value);
}
+static void test_visitor_in_large_number(TestInputVisitorData *data,
+ const void *unused)
+{
+ Error *err = NULL;
+ double res = 0;
+ int64_t i64;
+ uint64_t u64;
+ Visitor *v;
+
+ v = visitor_input_test_init(data, "-18446744073709551616"); /* -2^64 */
+
+ visit_type_number(v, NULL, &res, &error_abort);
+ g_assert_cmpfloat(res, ==, -18446744073709552e3);
+
+ visit_type_int(v, NULL, &i64, &err);
+ error_free_or_abort(&err);
+
+ visit_type_uint64(v, NULL, &u64, &err);
+ error_free_or_abort(&err);
+}
+
static void test_visitor_in_number_keyval(TestInputVisitorData *data,
const void *unused)
{
@@ -1253,6 +1287,8 @@ int main(int argc, char **argv)
NULL, test_visitor_in_bool_str_fail);
input_visitor_test_add("/visitor/input/number",
NULL, test_visitor_in_number);
+ input_visitor_test_add("/visitor/input/large_number",
+ NULL, test_visitor_in_large_number);
input_visitor_test_add("/visitor/input/number_keyval",
NULL, test_visitor_in_number_keyval);
input_visitor_test_add("/visitor/input/number_str_keyval",
--
2.13.0.91.g00982b8dd
- [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 00/43] qobject/qapi: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 01/43] qdev: remove PropertyInfo.qtype field, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 02/43] object: fix potential leak in getters, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 03/43] tests: Remove test cases for alternates of 'number' and 'int', Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 04/43] tests: add more int/number ranges checks,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 05/43] qapi: minor refactoring, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 07/43] qapi: Remove visit_start_alternate() parameter promote_int, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 06/43] qapi: merge QInt and QFloat in QNum, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 08/43] tests: remove /{qnum, qlist, dict}/destroy test, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 09/43] qnum: add uint type, Marc-André Lureau, 2017/06/07
- [Qemu-devel] [PATCH v3 10/43] json: learn to parse uint64 numbers, Marc-André Lureau, 2017/06/07