qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] test-char: start a /char/serial test


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 3/3] test-char: start a /char/serial test
Date: Thu, 8 Jun 2017 08:29:58 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 06/08/2017 06:59 AM, Marc-André Lureau wrote:
> Quite limited test, to check that the chardev can be created with a
> path and with the tty alias.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  tests/test-char.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/tests/test-char.c b/tests/test-char.c
> index dfe856cb85..ecc3fec194 100644
> --- a/tests/test-char.c
> +++ b/tests/test-char.c
> @@ -5,6 +5,7 @@
>  #include "qemu/config-file.h"
>  #include "qemu/sockets.h"
>  #include "chardev/char-fe.h"
> +#include "chardev/char-serial.h" /* for HAVE_CHARDEV_SERIAL */

Either the comment or the entire #include is now spurious, given the new
1/3.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]