[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/41] tests: add more int/number ranges checks
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 04/41] tests: add more int/number ranges checks |
Date: |
Fri, 9 Jun 2017 15:46:48 +0200 |
From: Marc-André Lureau <address@hidden>
Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[test_visitor_in_uint() tightened slightly]
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/test-qobject-input-visitor.c | 39 +++++++++++++++++++++++++++++++++++++-
1 file changed, 38 insertions(+), 1 deletion(-)
diff --git a/tests/test-qobject-input-visitor.c
b/tests/test-qobject-input-visitor.c
index 83d663d..4dc9c03 100644
--- a/tests/test-qobject-input-visitor.c
+++ b/tests/test-qobject-input-visitor.c
@@ -107,6 +107,7 @@ static void test_visitor_in_int(TestInputVisitorData *data,
const void *unused)
{
int64_t res = 0;
+ double dbl;
int value = -42;
Visitor *v;
@@ -114,6 +115,9 @@ static void test_visitor_in_int(TestInputVisitorData *data,
visit_type_int(v, NULL, &res, &error_abort);
g_assert_cmpint(res, ==, value);
+
+ visit_type_number(v, NULL, &dbl, &error_abort);
+ g_assert_cmpfloat(dbl, ==, -42.0);
}
static void test_visitor_in_uint(TestInputVisitorData *data,
@@ -121,6 +125,8 @@ static void test_visitor_in_uint(TestInputVisitorData *data,
{
Error *err = NULL;
uint64_t res = 0;
+ int64_t i64;
+ double dbl;
int value = 42;
Visitor *v;
@@ -129,8 +135,13 @@ static void test_visitor_in_uint(TestInputVisitorData
*data,
visit_type_uint64(v, NULL, &res, &error_abort);
g_assert_cmpuint(res, ==, (uint64_t)value);
+ visit_type_int(v, NULL, &i64, &error_abort);
+ g_assert_cmpint(i64, ==, value);
+
+ visit_type_number(v, NULL, &dbl, &error_abort);
+ g_assert_cmpfloat(dbl, ==, value);
+
/* BUG: value between INT64_MIN and -1 accepted modulo 2^64 */
-
v = visitor_input_test_init(data, "%d", -value);
visit_type_uint64(v, NULL, &res, &error_abort);
@@ -142,6 +153,9 @@ static void test_visitor_in_uint(TestInputVisitorData *data,
visit_type_uint64(v, NULL, &res, &err);
error_free_or_abort(&err);
+
+ visit_type_number(v, NULL, &dbl, &error_abort);
+ g_assert_cmpfloat(dbl, ==, 18446744073709552000.0);
}
static void test_visitor_in_int_overflow(TestInputVisitorData *data,
@@ -260,6 +274,27 @@ static void test_visitor_in_number(TestInputVisitorData
*data,
g_assert_cmpfloat(res, ==, value);
}
+static void test_visitor_in_large_number(TestInputVisitorData *data,
+ const void *unused)
+{
+ Error *err = NULL;
+ double res = 0;
+ int64_t i64;
+ uint64_t u64;
+ Visitor *v;
+
+ v = visitor_input_test_init(data, "-18446744073709551616"); /* -2^64 */
+
+ visit_type_number(v, NULL, &res, &error_abort);
+ g_assert_cmpfloat(res, ==, -18446744073709552e3);
+
+ visit_type_int(v, NULL, &i64, &err);
+ error_free_or_abort(&err);
+
+ visit_type_uint64(v, NULL, &u64, &err);
+ error_free_or_abort(&err);
+}
+
static void test_visitor_in_number_keyval(TestInputVisitorData *data,
const void *unused)
{
@@ -1253,6 +1288,8 @@ int main(int argc, char **argv)
NULL, test_visitor_in_bool_str_fail);
input_visitor_test_add("/visitor/input/number",
NULL, test_visitor_in_number);
+ input_visitor_test_add("/visitor/input/large_number",
+ NULL, test_visitor_in_large_number);
input_visitor_test_add("/visitor/input/number_keyval",
NULL, test_visitor_in_number_keyval);
input_visitor_test_add("/visitor/input/number_str_keyval",
--
2.7.5
- [Qemu-devel] [PULL 02/41] object: fix potential leak in getters, (continued)
- [Qemu-devel] [PULL 02/41] object: fix potential leak in getters, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 05/41] qapi: Clean up qobject_input_type_number() control flow, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 03/41] tests: Remove test cases for alternates of 'number' and 'int', Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 01/41] qdev: remove PropertyInfo.qtype field, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 09/41] qnum: add uint type, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 10/41] json: learn to parse uint64 numbers, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 12/41] object: add uint property setter/getter, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 11/41] qapi: update the qobject visitor to use QNUM_U64, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 20/41] isa: use get_uint() for "io-base", Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 16/41] qdev: wrap default property value in an union, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 04/41] tests: add more int/number ranges checks,
Markus Armbruster <=
- [Qemu-devel] [PULL 35/41] auxbus: use get_uint() for "addr" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 24/41] aspeed: use {set, get}_uint() for "ram-size" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 29/41] acpi: use get_uint() for "pci-hole*" properties, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 15/41] qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED(), Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 33/41] xen: use get_uint() for "max-ram-below-4g" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 40/41] console: use get_uint() for "head" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 26/41] platform-bus: use get_uint() for "addr" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 30/41] pc: use get_uint() for "iobase" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 36/41] pvpanic: use get_uint() for "ioport" property, Markus Armbruster, 2017/06/09
- [Qemu-devel] [PULL 23/41] pcihp: use get_uint() for "bsel" property, Markus Armbruster, 2017/06/09