[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw
|
From: |
Mark Cave-Ayland |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/6] fw_cfg: move qdev_init_nofail() out from fw_cfg_init1() into callers |
|
Date: |
Mon, 12 Jun 2017 12:54:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 12/06/17 12:43, Igor Mammedov wrote:
> On Sat, 10 Jun 2017 13:30:17 +0100
> Mark Cave-Ayland <address@hidden> wrote:
>
> patch needs a commit message saying why it's needed.
> maybe add something similar to:
>
> qdev_init_nofail() essentially 'realizes' object,
> taking in account that fw_cfg_init1() will be moved to
> realize in follow up patches, move qdev_init_nofail() outside of
> fw_cfg_init1().
Yes, I can alter the commit message to provide more explanation. For
some background the use case can be found in my follow-up sun4u patches
here (i.e. preparation for moving the ebus device behind a PCI bridge):
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg02658.html
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg02656.html
ATB,
Mark.
[Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init, Mark Cave-Ayland, 2017/06/10
[Qemu-devel] [PATCH 5/6] fw_cfg: use sysbus_init_mmio() in fw_cfg_io_realize(), Mark Cave-Ayland, 2017/06/10