[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/7] target-m68k: move fmove CR to a function |
Date: |
Mon, 12 Jun 2017 09:13:27 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/11/2017 04:16 PM, Laurent Vivier wrote:
Move code of fmove to/from control register to a function
Signed-off-by: Laurent Vivier <address@hidden>
---
target/m68k/translate.c | 66 ++++++++++++++++++++++++++++++-------------------
1 file changed, 41 insertions(+), 25 deletions(-)
In that this is 100% code movement,
Reviewed-by: Richard Henderson <address@hidden>
+ cpu_abort(NULL, "Unimplemented: fmove from control %d", mask);
+ goto undef;
But cpu_abort doesn't return, and will exit qemu.
This should be qemu_log_mask(LOG_UNIMP, ...).
r~
- [Qemu-devel] [PATCH v4 0/7] target-m68k: implement 680x0 FPU, Laurent Vivier, 2017/06/11
- [Qemu-devel] [PATCH v4 1/7] softfloat: define 680x0 specific values, Laurent Vivier, 2017/06/11
- [Qemu-devel] [PATCH v4 2/7] target-m68k: move FPU helpers to fpu_helper.c, Laurent Vivier, 2017/06/11
- [Qemu-devel] [PATCH v4 6/7] target-m68k: define 96bit FP registers for gdb on 680x0, Laurent Vivier, 2017/06/11
- [Qemu-devel] [PATCH v4 3/7] target-m68k: define ext_opsize, Laurent Vivier, 2017/06/11
- [Qemu-devel] [PATCH v4 7/7] target-m68k: add FPCR and FPSR, Laurent Vivier, 2017/06/11
- [Qemu-devel] [PATCH v4 5/7] target-m68k: use floatx80 internally, Laurent Vivier, 2017/06/11