qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 02/14] migration: Don't try to set *errp directly


From: Juan Quintela
Subject: [Qemu-devel] [PULL 02/14] migration: Don't try to set *errp directly
Date: Tue, 13 Jun 2017 11:51:08 +0200

From: Eduardo Habkost <address@hidden>

Assigning directly to *errp is not valid, as errp may be NULL,
&error_fatal, or &error_abort.  Use error_propagate() instead.

Cc: Juan Quintela <address@hidden>
Cc: "Dr. David Alan Gilbert" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
 migration/migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/migration.c b/migration/migration.c
index 9dfa19a..ae087df 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1179,7 +1179,7 @@ bool migration_is_blocked(Error **errp)
     }
 
     if (migration_blockers) {
-        *errp = error_copy(migration_blockers->data);
+        error_propagate(errp, error_copy(migration_blockers->data));
         return true;
     }
 
-- 
2.9.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]