[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex |
Date: |
Fri, 16 Jun 2017 08:12:58 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, 06/08 19:56, Fam Zheng wrote:
> From: Paolo Bonzini <address@hidden>
>
> It protects only the list of dirty bitmaps; in the next patch we will
> also protect their content.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/dirty-bitmap.c | 44 +++++++++++++++++++++++++++++++++++++++++++-
> block/mirror.c | 3 ++-
> blockdev.c | 44 +++++++-------------------------------------
> include/block/block_int.h | 5 +++++
> migration/block.c | 6 ------
> 5 files changed, 57 insertions(+), 45 deletions(-)
Squashing in this hunk for v4 (and have my fingers crossed :)
diff --git a/block.c b/block.c
index XXXXXXX..XXXXXXX XXXXXX
--- a/block.c
+++ b/block.c
@@ -XXX,X +XXX,X @@ BlockDriverState *bdrv_new(void)
}
notifier_with_return_list_init(&bs->before_write_notifiers);
qemu_co_mutex_init(&bs->reqs_lock);
+ qemu_mutex_init(&bs->dirty_bitmap_mutex);
bs->refcnt = 1;
bs->aio_context = qemu_get_aio_context();
- [Qemu-devel] [PULL v3 11/23] throttle-groups: only start one coroutine from drained_begin, (continued)
- [Qemu-devel] [PULL v3 11/23] throttle-groups: only start one coroutine from drained_begin, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 12/23] throttle-groups: do not use qemu_co_enter_next, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 13/23] throttle-groups: protect throttled requests with a CoMutex, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 10/23] block: access io_plugged with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 14/23] util: add stats64 module, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 15/23] block: use Stat64 for wr_highest_offset, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 16/23] block: access write_gen with atomics, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before reading, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 17/23] block: protect tracked_requests and flush_queue with reqs_lock, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex, Fam Zheng, 2017/06/08
- Re: [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex,
Fam Zheng <=
- [Qemu-devel] [PULL v3 20/23] block: protect modification of dirty bitmaps with a mutex, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 21/23] block: introduce block_account_one_io, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 22/23] block: split BlockAcctStats creation and setup, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 23/23] block: make accounting thread-safe, Fam Zheng, 2017/06/08
- Re: [Qemu-devel] [PULL v3 00/23] Docker and block patches, Peter Maydell, 2017/06/12