[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function |
Date: |
Mon, 19 Jun 2017 14:47:16 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 15.06.2017 um 18:38 hat Stefan Hajnoczi geschrieben:
> Avoid duplicating the QEMU command-line.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/qemu-iotests/068 | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qemu-iotests/068 b/tests/qemu-iotests/068
> index 9c1687d..653e23c 100755
> --- a/tests/qemu-iotests/068
> +++ b/tests/qemu-iotests/068
> @@ -59,14 +59,17 @@ case "$QEMU_DEFAULT_MACHINE" in
> ;;
> esac
>
> -# Give qemu some time to boot before saving the VM state
> -bash -c 'sleep 1; echo -e "savevm 0\nquit"' |\
> +_qemu()
> +{
> $QEMU $platform_parm -nographic -monitor stdio -serial none -hda
> "$TEST_IMG" |\
This line shouldn't end with a pipe now. The bug goes away with the next
patch anyway, so I can just remove that one character while applying the
series.
> + "$@" |\
> _filter_qemu | _filter_hmp
> +}
Kevin
[Qemu-devel] [PATCH 4/5] qemu-iotests: 068: use -drive/-device instead of -hda, Stefan Hajnoczi, 2017/06/15
[Qemu-devel] [PATCH 5/5] qemu-iotests: 068: test iothread mode, Stefan Hajnoczi, 2017/06/15
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Stefan Hajnoczi, 2017/06/15