Re: [Qemu-devel] [PATCH v3 1/2] tests: Add test-listen - a stress test for QEMU socket listen

[Daniel P. Berrange]

On Tue, Jun 20, 2017 at 10:58:43PM +0200, Knut Omang wrote:
> On Fri, 2017-06-16 at 15:41 +0100, Daniel P. Berrange wrote:
> > On Wed, Jun 14, 2017 at 06:53:51PM +0200, Knut Omang wrote:
> > > +static void listen_compete(void)
> > > +{
> > > +    listen_compete_nthr(true, 200, 5920, 300);
> > > +}
> > > +
> > > +static void listen_serial(void)
> > > +{
> > > +    listen_compete_nthr(false, 200, 6300, 300);
> > > +}
> > > +
> > > +
> > > +int main(int argc, char **argv)
> > > +{
> > > +    g_test_init(&argc, &argv, NULL);
> > > +
> > > +    g_test_add_func("/socket/listen-serial", listen_serial);
> > > +    g_test_add_func("/socket/listen-compete", listen_compete);
> > 
> > Not all our CI systems have network access. You'll want todo a check for
> > access first, and exit if not available. See check_protocol_support() in
> > test-io-channel-socket.c for example.
> 
> Will do 
> - maybe these functions could be made part of the test framework to avoid
> duplication?

Sure, pulling the code out into a common helper file is a fine idea.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|