Re: [Qemu-devel] [PATCH v3 11/13] migration: move only_migratable to MigrationState

[Peter Xu]

On Mon, Jun 19, 2017 at 05:50:50PM +0200, Juan Quintela wrote:
> Peter Xu <address@hidden> wrote:
> > One less global variable, and it does only matter with migration.
> >
> > We keep the old "--only-migratable" option, but also now we support:
> >
> >   -global migration.only-migratable=true
> >
> > Currently still keep the old interface.
> >
> > Hmm, now vl.c has no way to access migrate_get_current(). Export a
> > function for it to setup only_migratable.
> >
> > Signed-off-by: Peter Xu <address@hidden>
> 
> Reviewed-by: Juan Quintela <address@hidden>
> 
> If you have to respin

So there will be. :-)

> 
> +void migration_only_migratable_set(bool only_migratable);
> +
> 
> only is used with "true".  I think that it is easier without parameter.
> 
> But it is just a question of taste, so, as you are the one doing the
> code ....

Sure.  Thanks,

-- 
Peter Xu