Re: [Qemu-devel] [PATCH] Improve Cocoa modifier key handling

[G 3]

On Jun 24, 2017, at 8:14 AM, Peter Maydell wrote:

> On 23 June 2017 at 21:05, Programmingkid  
> <address@hidden> wrote:
> > This patch is incompatible with anything below Mac OS 10.10.
>
> Oops. Thanks for the report.
>
> > We support Mac OS 10.5 and up. I was able to make this patch work
> > on Mac OS 10.6 by changing this line:
> >
> > NSEventModifierFlags modifiers = [event modifierFlags];
> >
> > to this:
> >
> > NSUInteger modifiers = [event modifierFlags];
> >
> > This wouldn't be enough. The [event modifierFlags] code would have to
> > be replaced because the modifierFlags function is not available on
> > Mac OS 10.5.

Please disregard what I said about the [event modifierFlags] code. It  
turns out it has been available since Mac OS 10.0. Sorry for the  
mistake.


> Do you still use 10.5? It's a decade old now, and I notice that
> in the QEMU 2.5 changelog we actually said we were going to
> remove 10.5 support. So one option would be to simply remove
> 10.5 support entirely, if nobody needs it any more.

I do have a computer with 10.5 on it. I will be happy to help support  
Mac OS 10.5.