Re: [Qemu-devel] [PATCH v3 4/7] softfloat: define floatx80_round()

[Aurelien Jarno]

On 2017-06-27 21:12, Laurent Vivier wrote:
> Add a function to round a floatx80 to the defined precision
> (floatx80_rounding_precision)
> 
> Signed-off-by: Laurent Vivier <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> ---
>  fpu/softfloat.c         | 15 +++++++++++++++
>  include/fpu/softfloat.h |  1 +
>  2 files changed, 16 insertions(+)
> 
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 7af14e2..e9bf359 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -5086,6 +5086,21 @@ float128 floatx80_to_float128(floatx80 a, float_status 
> *status)
>  }
>  
>  
> /*----------------------------------------------------------------------------
> +| Rounds the extended double-precision floating-point value `a'

Maybe it is worth mentioning the precision to which the value is rounded
(floatx80_rounding_precision) ?

Otherwise looks all fine to me.

Reviewed-by: Aurelien Jarno <address@hidden>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net