Re: [Qemu-devel] [PATCH v6 4/4] net/socket: Improve -net socket error reporting

[Markus Armbruster]

Mao Zhongyi <address@hidden> writes:

> Hi, Daniel
>
> On 06/28/2017 09:27 PM, Daniel P. Berrange wrote:
>> On Wed, Jun 28, 2017 at 09:08:50PM +0800, Mao Zhongyi wrote:
>>> When -net socket fails, it first reports a specific error, then
>>> a generic one, like this:
>>>
>>>     $ qemu-system-x86_64 -net socket,
>>>     qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, 
>>> mcast= or udp= is required
>>>     qemu-system-x86_64: -net socket: Device 'socket' could not be 
>>> initialized
>>
>> This second line of error message comes from net/net.c in the
>> net_client_init1 method:
>>
>>         /* FIXME drop when all init functions store an Error */
>>         if (errp && !*errp) {
>>             error_setg(errp, QERR_DEVICE_INIT_FAILED,
>>                        NetClientDriver_lookup[netdev->type]);
>>         }
>>
>>
>> hopefully your patch could drop this code too ?
>>
>> In fact this is the only use of QERR_DEVICE_INIT_FAILED in the
>> whole tree, so the QERR constant could possibly be killed too.
>>
>
> OK, I will. :)

You can do that only when *all* init functions stor an Error!  We're not
there, yet:

    $ grep 'FIXME error_setg' net/*
    net/l2tpv3.c:    /* FIXME error_setg(errp, ...) on failure */
    net/slirp.c:    /* FIXME error_setg(errp, ...) on failure */
    net/socket.c:    /* FIXME error_setg(errp, ...) on failure */
    net/tap-win32.c:    /* FIXME error_setg(errp, ...) on failure */
    net/vde.c:    /* FIXME error_setg(errp, ...) on failure */