[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 3/6] hw/acpi: fix pcihp io initialization
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC 3/6] hw/acpi: fix pcihp io initialization |
Date: |
Fri, 30 Jun 2017 02:22:14 +0300 |
On Fri, Jun 30, 2017 at 12:55:59AM +0300, Aleksandr Bezzubikov wrote:
> Signed-off-by: Aleksandr Bezzubikov <address@hidden>
Any data on what is wrong with the current code?
Pls include this in commit log.
> ---
> hw/i386/acpi-build.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index b0dcd34..c99dbcc 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -129,17 +129,18 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> Object *lpc = ich9_lpc_find();
> Object *obj = NULL;
> QObject *o;
> + int pcihp_io_len, pcihp_io_base;
>
> pm->cpu_hp_io_base = 0;
> - pm->pcihp_io_base = 0;
> - pm->pcihp_io_len = 0;
> if (piix) {
> obj = piix;
> pm->cpu_hp_io_base = PIIX4_CPU_HOTPLUG_IO_BASE;
> - pm->pcihp_io_base =
> + pcihp_io_base =
> object_property_get_int(obj, ACPI_PCIHP_IO_BASE_PROP, NULL);
> - pm->pcihp_io_len =
> + pcihp_io_len =
> object_property_get_int(obj, ACPI_PCIHP_IO_LEN_PROP, NULL);
> + pm->pcihp_io_base = (pcihp_io_base == -1) ? 0 : pcihp_io_base;
> + pm->pcihp_io_len = (pcihp_io_len == -1) ? 0 : pcihp_io_len;
> }
> if (lpc) {
> obj = lpc;
> --
> 2.7.4
- [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support, Aleksandr Bezzubikov, 2017/06/29
- [Qemu-devel] [PATCH RFC 4/6] hw/acpi: prepare pci hotplug IO for ich9, Aleksandr Bezzubikov, 2017/06/29
- [Qemu-devel] [PATCH RFC 2/6] hw/acpi: simplify dsdt building code, Aleksandr Bezzubikov, 2017/06/29
- [Qemu-devel] [PATCH RFC 3/6] hw/acpi: fix pcihp io initialization, Aleksandr Bezzubikov, 2017/06/29
- Re: [Qemu-devel] [PATCH RFC 3/6] hw/acpi: fix pcihp io initialization,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH RFC 1/6] hw/acpi: remove dead acpi code, Aleksandr Bezzubikov, 2017/06/29
- [Qemu-devel] [PATCH RFC 5/6] hw/acpi: extend acpi pci hotplug support for pci express, Aleksandr Bezzubikov, 2017/06/29
- [Qemu-devel] [PATCH RFC 6/6] hw/ich9: enable acpi pci hotplug, Aleksandr Bezzubikov, 2017/06/29
- Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support, Michael S. Tsirkin, 2017/06/29