[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean |
Date: |
Thu, 6 Jul 2017 16:20:48 -1000 |
If we mask off any out-of-band bits before we assign to the
variable, then we don't need to clean it up when reading.
Signed-off-by: Richard Henderson <address@hidden>
---
target/sh4/cpu.h | 2 +-
target/sh4/cpu.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/sh4/cpu.h b/target/sh4/cpu.h
index 240ed36..6d179a7 100644
--- a/target/sh4/cpu.h
+++ b/target/sh4/cpu.h
@@ -391,7 +391,7 @@ static inline void cpu_get_tb_cpu_state(CPUSH4State *env,
target_ulong *pc,
{
*pc = env->pc;
*cs_base = 0;
- *flags = (env->flags & TB_FLAG_ENVFLAGS_MASK) /* Bits 0-2 */
+ *flags = env->flags /* Bits 0-2 */
| (env->fpscr & (FPSCR_FR | FPSCR_SZ | FPSCR_PR)) /* Bits 19-21 */
| (env->sr & ((1u << SR_MD) | (1u << SR_RB))) /* Bits 29-30 */
| (env->sr & (1u << SR_FD)) /* Bit 15 */
diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c
index 9da7e1e..8536f6d 100644
--- a/target/sh4/cpu.c
+++ b/target/sh4/cpu.c
@@ -39,7 +39,7 @@ static void superh_cpu_synchronize_from_tb(CPUState *cs,
TranslationBlock *tb)
SuperHCPU *cpu = SUPERH_CPU(cs);
cpu->env.pc = tb->pc;
- cpu->env.flags = tb->flags;
+ cpu->env.flags = tb->flags & TB_FLAG_ENVFLAGS_MASK;
}
static bool superh_cpu_has_work(CPUState *cs)
--
2.9.4
- [Qemu-devel] [PATCH v2 00/27] target/sh4 improvements, Richard Henderson, 2017/07/06
- [Qemu-devel] [PATCH v2 01/27] target/sh4: Use cmpxchg for movco, Richard Henderson, 2017/07/06
- [Qemu-devel] [PATCH v2 02/27] target/sh4: Consolidate end-of-TB tests, Richard Henderson, 2017/07/06
- [Qemu-devel] [PATCH v2 03/27] target/sh4: Introduce TB_FLAG_ENVFLAGS_MASK, Richard Henderson, 2017/07/06
- [Qemu-devel] [PATCH v2 04/27] target/sh4: Keep env->flags clean,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 05/27] target/sh4: Adjust TB_FLAG_PENDING_MOVCA, Richard Henderson, 2017/07/06
- [Qemu-devel] [PATCH v2 06/27] target/sh4: Handle user-space atomics, Richard Henderson, 2017/07/06