qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 18/27] target/sh4: Unify code for CHECK_NOT_D


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v2 18/27] target/sh4: Unify code for CHECK_NOT_DELAY_SLOT
Date: Sat, 8 Jul 2017 13:59:13 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/06/2017 11:21 PM, Richard Henderson wrote:
We do not need to emit N copies of raising an exception.

Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

---
  target/sh4/translate.c | 11 +++++------
  1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 3453f19..41157a0 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -377,11 +377,8 @@ static inline void gen_store_fpr64(DisasContext *ctx, 
TCGv_i64 t, int reg)
  #define XHACK(x) ((((x) & 1 ) << 4) | ((x) & 0xe))
#define CHECK_NOT_DELAY_SLOT \
-    if (ctx->envflags & DELAY_SLOT_MASK) {                           \
-        gen_save_cpu_state(ctx, true);                               \
-        gen_helper_raise_slot_illegal_instruction(cpu_env);          \
-        ctx->bstate = BS_EXCP;                                       \
-        return;                                                      \
+    if (ctx->envflags & DELAY_SLOT_MASK) {  \
+        goto do_illegal_slot;               \
      }
#define CHECK_PRIVILEGED \
@@ -1820,10 +1817,12 @@ static void _decode_opc(DisasContext * ctx)
            ctx->opcode, ctx->pc);
      fflush(stderr);
  #endif
-    gen_save_cpu_state(ctx, true);
      if (ctx->envflags & DELAY_SLOT_MASK) {
+ do_illegal_slot:
+        gen_save_cpu_state(ctx, true);
          gen_helper_raise_slot_illegal_instruction(cpu_env);
      } else {
+        gen_save_cpu_state(ctx, true);
          gen_helper_raise_illegal_instruction(cpu_env);
      }
      ctx->bstate = BS_EXCP;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]