Re: [Qemu-devel] [PATCH 02/11] memory: Document that the RAM MR initializers do not handle migration

[Peter Maydell]

On 10 July 2017 at 11:05, Paolo Bonzini <address@hidden> wrote:
>
>
> On 10/07/2017 12:04, Peter Maydell wrote:
>> On 10 July 2017 at 11:01, Paolo Bonzini <address@hidden> wrote:
>>>
>>>
>>> On 07/07/2017 16:42, Peter Maydell wrote:
>>>> @@ -522,6 +537,9 @@ void memory_region_init_ram_ptr(MemoryRegion *mr,
>>>>   * @name: the name of the region.
>>>>   * @size: size of the region.
>>>>   * @ptr: memory to be mapped; must contain at least @size bytes.
>>>> + *
>>>> + * Note that this function does not do anything to cause the data in the
>>>> + * RAM memory region to be migrated; that is the responsibility of the 
>>>> caller.
>>>
>>> Perhaps add a note that it rarely makes sense for this function?
>>
>> Well, we have 4 callers of this function, and 3 of those
>> register the RAM for migration, so the rare case seems to be
>> the "don't need to handle migration"...
>
> Oops, the diff header is confusing and I didn't notice that when
> trimming.  My comment refers to RAM device regions.

Yeah, no objection to adding a note for that one.

thanks
-- PMM