Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

[Philippe Mathieu-Daudé]

Hi Alistair,

On 07/10/2017 05:06 AM, Markus Armbruster wrote:
> Alistair Francis <address@hidden> writes:
> > Yeah, I thought I saw this when I was doing it, but then everything
> > compiled so I figured it was fine.
> >
> > It must not all be included with the default ./configure, because I
> > just tried again and it all compiles for me.
>
> The result of ./configure depends on the packages you got installed.
> You need quite a few development packages to get anywhere near a full
> compile.  For a first step, you could do worse than installing your
> distribution's QEMU package's build dependencies.

To avoid to install development packages on your host you can build 
using docker images which intend to cover the whole code base installing 
many dependencies.

For example (I don't have libiscsi installed on my workstation):

$ make address@hidden
  BUILD   debian
  BUILD   debian-mipsel-cross
...
Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu 
--prefix=/var/tmp/qemu-build/install --cross-prefix=mipsel-linux-gnu-
...
libiscsi support  yes
libnfs support    yes
build guest agent yes
...
  CC      nbd/server.o
  CC      nbd/client.o
  CC      nbd/common.o
  CC      block/iscsi.o
/tmp/qemu-test/src/block/iscsi.c: In function 'iscsi_open':
/tmp/qemu-test/src/block/iscsi.c:1764:21: error: character constant too 
long for its type [-Werror]
         warn_report('filename' option specified. "
                     ^
/tmp/qemu-test/src/block/iscsi.c:1764:32: error: expected ')' before 
'option'
         warn_report('filename' option specified. "
                                ^
/tmp/qemu-test/src/block/iscsi.c:1764:50: error: missing terminating " 
character [-Werror]
         warn_report('filename' option specified. "
                                                  ^
/tmp/qemu-test/src/block/iscsi.c:1764:32: error: missing terminating " 
character
         warn_report('filename' option specified. "
                                ^
/tmp/qemu-test/src/block/iscsi.c:1764:21: error: passing argument 1 of 
'warn_report' makes pointer from integer without a cast [-Werror]
         warn_report('filename' option specified. "
                     ^
In file included from /tmp/qemu-test/src/block/iscsi.c:33:0:
/tmp/qemu-test/src/include/qemu/error-report.h:44:6: note: expected 
'const char *' but argument is of type 'int'
 void warn_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
      ^
/tmp/qemu-test/src/block/iscsi.c:1766:23: error: format not a string 
literal and no format arguments [-Werror=format-security]
                       "in the future");
                       ^
cc1: all warnings being treated as errors
/tmp/qemu-test/src/rules.mak:66: recipe for target 'block/iscsi.o' failed
make: *** [block/iscsi.o] Error 1
tests/docker/Makefile.include:122: recipe for target 'docker-run' failed
make[1]: *** [docker-run] Error 2
make: *** address@hidden Error 2

Regards,

Phil.