[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn |
Date: |
Tue, 11 Jul 2017 10:34:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 11/07/2017 10:28, Kevin Wolf wrote:
> Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben:
>> It is called from qcow2_invalidate_cache in coroutine context, so always
>> load metadata from a coroutine.
>> ---
>> block/qcow2.c | 45 ++++++++++++++++++++++++++++++++++++++++-----
>> 1 file changed, 40 insertions(+), 5 deletions(-)
>
> Missing S-o-b on patches 1 and 2?
Oops, yes. Though I don't think these patches are for 2.10. They are
on top of Stefan's bdrv_co_create series, by the way.
Paolo
> These patches suggest that .bdrv_co_open() might be the next thing to
> get rid of the coroutine wrappers again in driver code. But we'll always
> have some wrappers in the drivers in an intermediate state, so doing
> .bdrv_invalidate_cache first is fine.
>
> Kevin
>
[Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn, Paolo Bonzini, 2017/07/10
[Qemu-devel] [PATCH 4/5] qcow2: introduce qcow2_write_caches and qcow2_flush_caches, Paolo Bonzini, 2017/07/10
[Qemu-devel] [PATCH 2/5] qed: make bdrv_qed_do_open a coroutine_fn, Paolo Bonzini, 2017/07/10