Re: [Qemu-devel] [PATCH v3 00/10] Implement network booting directly into the s390-ccw BIOS

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v3 00/10] Implement network booting directly into 
the s390-ccw BIOS

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7a8436f pc-bios/s390-ccw: Link libnet into the netboot image and do the TFTP 
load
5b80edd pc-bios/s390-ccw: Add virtio-net driver code
60c08d0 pc-bios/s390-ccw: Add core files for the network bootloading program
ff6bc23 roms/SLOF: Update submodule to latest status
10ae122 pc-bios/s390-ccw: Add code for virtio feature negotiation
b466c2a pc-bios/s390-ccw: Move byteswap functions to a separate header
834518a pc-bios/s390-ccw: Add a write() function for stdio
2f7123d pc-bios/s390-ccw: Move virtio-block related functions into a separate 
file
9798a47 pc-bios/s390-ccw: Move ebc2asc to sclp.c
160d33a pc-bios/s390-ccw: Move libc functions to separate header

=== OUTPUT BEGIN ===
Checking PATCH 1/10: pc-bios/s390-ccw: Move libc functions to separate header...
Checking PATCH 2/10: pc-bios/s390-ccw: Move ebc2asc to sclp.c...
Checking PATCH 3/10: pc-bios/s390-ccw: Move virtio-block related functions into 
a separate file...
Checking PATCH 4/10: pc-bios/s390-ccw: Add a write() function for stdio...
ERROR: externs should be avoided in .c files
#23: FILE: pc-bios/s390-ccw/sclp.c:15:
+long write(int fd, const void *buf, size_t len);

total: 1 errors, 0 warnings, 37 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/10: pc-bios/s390-ccw: Move byteswap functions to a separate 
header...
Checking PATCH 6/10: pc-bios/s390-ccw: Add code for virtio feature 
negotiation...
Checking PATCH 7/10: roms/SLOF: Update submodule to latest status...
Checking PATCH 8/10: pc-bios/s390-ccw: Add core files for the network 
bootloading program...
ERROR: externs should be avoided in .c files
#120: FILE: pc-bios/s390-ccw/netmain.c:26:
+extern char _start[];

ERROR: externs should be avoided in .c files
#123: FILE: pc-bios/s390-ccw/netmain.c:29:
+IplParameterBlock iplb __attribute__((aligned(PAGE_SIZE)));

total: 2 errors, 0 warnings, 202 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/10: pc-bios/s390-ccw: Add virtio-net driver code...
Checking PATCH 10/10: pc-bios/s390-ccw: Link libnet into the netboot image and 
do the TFTP load...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden