[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn |
Date: |
Tue, 11 Jul 2017 16:26:29 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Jul 05, 2017 at 12:03:17AM +0200, Marc-André Lureau wrote:
> CC util/qemu-coroutine-lock.o
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:371:5: warning: calling
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_mutex_lock(&lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:371:5: warning: calling
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:374:9: warning: calling
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_queue_wait(&lock->queue, &lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:374:9: warning: calling
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:377:5: warning: calling
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_mutex_unlock(&lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:377:5: warning: calling
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:390:9: warning: calling
> function 'qemu_co_queue_restart_all' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_queue_restart_all(&lock->queue);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:390:9: warning: calling
> function 'qemu_co_queue_restart_all' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:394:9: warning: calling
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_mutex_lock(&lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:394:9: warning: calling
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:399:13: warning: calling
> function 'qemu_co_queue_next' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_queue_next(&lock->queue);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:399:13: warning: calling
> function 'qemu_co_queue_next' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:402:5: warning: calling
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_mutex_unlock(&lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:402:5: warning: calling
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:407:5: warning: calling
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_mutex_lock(&lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:407:5: warning: calling
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:410:9: warning: calling
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
> qemu_co_queue_wait(&lock->queue, &lock->mutex);
> ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:410:9: warning: calling
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn'
> exclusively [-Wthread-safety-analysis]
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> include/qemu/coroutine.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 02/35] WIP: coroutine: manually tag the fast-paths, (continued)
- [Qemu-devel] [PATCH 05/35] coroutine: remove coroutine_fn from qemu_co_queue_run_restart(), Marc-André Lureau, 2017/07/04
- [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn, Marc-André Lureau, 2017/07/04
- Re: [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 07/35] blockjob: mark coroutine_fn, Marc-André Lureau, 2017/07/04
- [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/04
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05