[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 6/9] qcow2: add bdrv_measure() support
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v9 6/9] qcow2: add bdrv_measure() support |
Date: |
Tue, 11 Jul 2017 13:59:53 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/05/2017 07:57 AM, Stefan Hajnoczi wrote:
> Use qcow2_calc_prealloc_size() to get the required file size.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> ---
>
> +static BlockMeasureInfo *qcow2_measure(QemuOpts *opts, BlockDriverState
> *in_bs,
> + } else {
> + int cluster_sectors = cluster_size / BDRV_SECTOR_SIZE;
> + int64_t sector_num;
> + int pnum = 0;
> +
> + for (sector_num = 0;
> + sector_num < ssize / BDRV_SECTOR_SIZE;
> + sector_num += pnum) {
> + int nb_sectors = MAX(ssize / BDRV_SECTOR_SIZE - sector_num,
> + INT_MAX);
> + BlockDriverState *file;
> + int64_t ret;
> +
> + ret = bdrv_get_block_status_above(in_bs, NULL,
> + sector_num, nb_sectors,
> + &pnum, &file);
Oh what fun. More sector-based iteration that I get to convert to
byte-based on another respin of my work ;)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v9 0/9] qemu-img: add measure sub-command, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 1/9] block: add bdrv_measure() API, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 2/9] raw-format: add bdrv_measure() support, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 3/9] qcow2: extract preallocation calculation function, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 5/9] qcow2: extract image creation option parsing, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 4/9] qcow2: make refcount size calculation conservative, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 6/9] qcow2: add bdrv_measure() support, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 7/9] qemu-img: add measure subcommand, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 8/9] qemu-iotests: support per-format golden output files, Stefan Hajnoczi, 2017/07/05
- [Qemu-devel] [PATCH v9 9/9] iotests: add test 178 for qemu-img measure, Stefan Hajnoczi, 2017/07/05
- Re: [Qemu-devel] [PATCH v9 0/9] qemu-img: add measure sub-command, Max Reitz, 2017/07/09