Re: [Qemu-devel] [RFC 01/29] RAMBlock/migration: Add migration flags

[Dr. David Alan Gilbert]

* Peter Xu (address@hidden) wrote:
> On Wed, Jun 28, 2017 at 08:00:19PM +0100, Dr. David Alan Gilbert (git) wrote:
> 
> [...]
> 
> > diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
> > index af5bf26080..0cb6c5cb73 100644
> > --- a/include/exec/ram_addr.h
> > +++ b/include/exec/ram_addr.h
> > @@ -32,6 +32,8 @@ struct RAMBlock {
> >      ram_addr_t max_length;
> >      void (*resized)(const char*, uint64_t length, void *host);
> >      uint32_t flags;
> > +    /* These flags are owned by migration, initialised to 0 */
> > +    uint32_t migration_flags;
> 
> Since we have RAMBlock.flags, would it be possible to use that
> directly? Currently it only used 3 bits.  Thanks,

OK, gone - we now have:
bool qemu_ram_is_uf_zeroable(RAMBlock *rb);
void qemu_ram_set_uf_zeroable(RAMBlock *rb);

which work on the new RAM_UF_ZEROPAGE flag.

Dave


> -- 
> Peter Xu
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK