[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function |
Date: |
Thu, 13 Jul 2017 13:22:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/13/2017 02:08 AM, Alistair Francis wrote:
>> On Wed, Jul 12, 2017 at 6:49 PM, Markus Armbruster <address@hidden> wrote:
>>> Alistair Francis <address@hidden> writes:
>>>
>>>> QEMU currently has a standard method to report errors with
>>>> error_repot(). This ensure a sane and standard format when printing
>>>> errors. This series is attempting to extend this functionality for
>>>> warnings and information as well.
>>>>
>>>> This patch renames error_print_loc() function to be more clear, but I
>>>> didn't bother renaming the others. It seems silly to change
>>>> error_printf() to error_warning_printf() and printf is already taken so
>>>> I just left it as is.
>>>
>>> I can take this through my tree once PATCH 4 got some R-by from PC
>>> paintainers. Whom you again neglected to cc; I just did that for you.
>>> I'll be happy to touch up minor issues like the ones I pointed out for
>>> v4.
>>
>> Thanks for CCing them. I keep assuming git send-email will CC from the
>> suggested-by line, but apparently not.
>
> It will, if you add 'git config sendemail.cccmd
> "/path/to/scripts/get_maintainer.pl --nogit-fallback --noroles"'
Misunderstanding? Your bit of configuration automates cc'ing
maintainers. Alistair was wondering about Suggested-by lines.
- Re: [Qemu-devel] [PATCH v4 4/7] hw/i386: Improve some of the warning messages, "Michael S. Tsirkin" <address@hidden>, Igor Mammedov <address@hidden>, Eduardo Habkost <address@hidden>, (continued)
- [Qemu-devel] [PATCH v4 6/7] error: Implement the warn and free Error functions, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 5/7] char-socket: Report TCP socket waiting as information, Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 3/7] Convert error_report() to warn_report(), Alistair Francis, 2017/07/12
- [Qemu-devel] [PATCH v4 7/7] Convert error_report*_err() to warn_report*_err(), Alistair Francis, 2017/07/12
- Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function, no-reply, 2017/07/12
- Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function, Markus Armbruster, 2017/07/12
Re: [Qemu-devel] [PATCH v4 0/7] Implement a warning_report function, no-reply, 2017/07/13