[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/29] qcow2: use DIV_ROUND_UP
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/29] qcow2: use DIV_ROUND_UP |
Date: |
Thu, 13 Jul 2017 15:20:01 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/13/2017 11:31 AM, Marc-André Lureau wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> block/qcow2-cluster.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index f06c08f64c..30db942dde 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -61,7 +61,7 @@ int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t
> min_size,
> new_l1_size = 1;
> }
> while (min_size > new_l1_size) {
> - new_l1_size = (new_l1_size * 3 + 1) / 2;
> + new_l1_size = DIV_ROUND_UP(new_l1_size * 3, 2);
> }
> }
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 05/29] i8254: use QEMU_ALIGN_DOWN, (continued)
- [Qemu-devel] [PATCH v2 05/29] i8254: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 04/29] vhost: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 06/29] pcspk: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 07/29] dmg: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 08/29] qcow2: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 09/29] vpc: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 10/29] vvfat: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 11/29] vnc: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13
- [Qemu-devel] [PATCH v2 12/29] ui: use DIV_ROUND_UP, Marc-André Lureau, 2017/07/13