Re: [Qemu-devel] [PULL v2 0/5] Merge sockets 2017/07/11

[Daniel P. Berrange]

On Fri, Jul 14, 2017 at 11:18:33AM +0200, Christian Borntraeger wrote:
> On 07/14/2017 10:36 AM, Peter Maydell wrote:
> > On 12 July 2017 at 17:18, Daniel P. Berrange <address@hidden> wrote:
> >> The following changes since commit 
> >> 3d0bf8dfdfebd7f2ae41b6f220444b8047d6b1ee:
> >>
> >>   Merge remote-tracking branch 
> >> 'remotes/dgilbert/tags/pull-migration-20170710a' into staging (2017-07-10 
> >> 18:13:03 +0100)
> >>
> >> are available in the git repository at:
> >>
> >>   git://github.com/berrange/qemu tags/pull-sockets-2017-07-11-2
> >>
> >> for you to fetch changes up to 4b1ac1b3abf0d07cd4d9f9011f12d62bff27154c:
> >>
> >>   tests: add functional test validating ipv4/ipv6 address flag handling 
> >> (2017-07-12 16:49:00 +0100)
> >>
> >> ----------------------------------------------------------------
> >> Merge sockets 2017/07/11 v2
> >>
> >> ----------------------------------------------------------------
> >> Daniel P. Berrange (5):
> >>   sockets: ensure we can bind to both ipv4 & ipv6 separately
> >>   sockets: don't block IPv4 clients when listening on "::"
> >>   sockets: ensure we don't accept IPv4 clients when IPv4 is disabled
> >>   io: preserve ipv4/ipv6 flags when resolving InetSocketAddress
> >>   tests: add functional test validating ipv4/ipv6 address flag handling
> > 
> > This failed 'make check' on s390x host:
> > 
> > TEST: tests/test-sockets-proto... (pid=28872)
> >   /sockets/migrate/wildcard/all:                                       OK
> > [...]
> >   /sockets/chardev/::/ipv4onipv6on:                                    OK
> >   /sockets/chardev/::/ipv4offipv6off:                                  OK
> >   /sockets/net/wildcard/all:                                           **
> > ERROR:/home/linux1/qemu/tests/test-sockets-proto.c:849:test_listen:
> > assertion failed: (data->ipv4 == 0)
> > FAIL
> > GTester: last random seed: R02S575d305465be93e6120318b4f8434263
> > (pid=29314)
> > FAIL: tests/test-sockets-proto
> > 
> 
> 
> FWIW, I tried to reproduce on my system (Fedora 24 s390x), 
> but qemu/master + this pull + configure + make check did compile the 
> test-sockets-proto
> test, but it does not execute it. Any idea why not?

It is only set to run with the  x86_64 system emulator by default, since I
felt it a waste of time to run the same test with multuple emulators as it
isn't arch specific.  eg  make check-qtest-x86_64   only


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|