[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] block: fix dangling bs->explicit_options
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] block: fix dangling bs->explicit_options in block.c |
|
Date: |
Fri, 14 Jul 2017 09:42:22 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/14/2017 09:35 AM, Manos Pitsidianakis wrote:
> In some error paths it is possible to QDECREF a freed dangling
> explicit_options, resulting in a heap overflow crash. For example
> bdrv_open_inherit()'s fail unrefs it, then calls bdrv_unref which calls
> bdrv_close which also unrefs it.
>
> Signed-off-by: Manos Pitsidianakis <address@hidden>
> ---
> block.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
Can you pinpoint which commit introduced the bug, in order to decide if
this affects 2.9 and should therefore be cc'd to qemu-stable?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature