[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report() |
Date: |
Mon, 17 Jul 2017 12:19:06 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben:
> From: Alistair Francis <address@hidden>
>
> Convert all uses of error_report("warning:"... to use warn_report()
> instead. This helps standardise on a single method of printing warnings
> to the user.
>
> All of the warnings were changed using these two commands:
> find ./* -type f -exec sed -i \
> 's|error_report(".*warning[,:] |warn_report("|Ig' {} +
>
> Indentation fixed up manually afterwards.
>
> The test-qdev-global-props test case was manually updated to ensure that
> this patch passes make check (as the test cases are case sensitive).
This patch broke qemu-iotests 051 because it neglected to update the
reference output. Not sure if a change of the message was even intended,
but with a error location prefix, the order changes:
-(qemu) QEMU_PROG: -drive if=scsi,media=cdrom: warning: bus=0,unit=0 is
deprecated with this machine type
+(qemu) warning: qemu-system-x86_64: -drive if=scsi,media=cdrom: bus=0,unit=0
is deprecated with this machine type
Personally, I would expect the error location or at least the program
name to come first even for warnings.
Kevin
- [Qemu-devel] [PULL 0/9] Error reporting patches for 2017-07-13, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 4/9] util/qemu-error: Rename error_print_loc() to be more generic, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 7/9] char-socket: Report TCP socket waiting as information, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 8/9] error: Implement the warn and free Error functions, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 3/9] websock: Don't try to set *errp directly, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 5/9] error: Functions to report warnings and informational messages, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 2/9] block: Don't try to set *errp directly, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 9/9] Convert error_report*_err() to warn_report*_err(), Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 1/9] xilinx: Fix latent error handling bug, Markus Armbruster, 2017/07/13
- [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/13
- Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(),
Kevin Wolf <=
- Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/18
- Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/24
- Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(), Paolo Bonzini, 2017/07/24
- [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()), Eduardo Habkost, 2017/07/25
- Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()), Alistair Francis, 2017/07/25
- Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()), Alistair Francis, 2017/07/25
- Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()), Richard W.M. Jones, 2017/07/26
- Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()), Daniel P. Berrange, 2017/07/26
- Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(), Daniel P. Berrange, 2017/07/26
- Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/27