[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add()
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add() |
Date: |
Mon, 17 Jul 2017 19:14:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> Abstracted from migrate_set_block_enabled() to allocate
> MigrationCapabilityStatusList properly.
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Nitpick
> -void migrate_set_block_enabled(bool value, Error **errp)
> +static MigrationCapabilityStatusList *migrate_cap_add(
> + MigrationCapabilityStatusList *head,
We have a parameter called head
> + MigrationCapability index,
> + bool state)
> {
> MigrationCapabilityStatusList *cap;
>
> cap = g_new0(MigrationCapabilityStatusList, 1);
> cap->value = g_new0(MigrationCapabilityStatus, 1);
> - cap->value->capability = MIGRATION_CAPABILITY_BLOCK;
> - cap->value->state = value;
> + cap->value->capability = index;
> + cap->value->state = state;
> + cap->next = head;
> +
> + return cap;
But we don't do the *head = cap?
Pelhaps is better to call it "next" or "list"?
- Re: [Qemu-devel] [PATCH v2 07/11] migration: check global params for validity, (continued)
[Qemu-devel] [PATCH v2 08/11] migration: remove check against colo support, Peter Xu, 2017/07/17
[Qemu-devel] [PATCH v2 09/11] migration: provide migrate_caps_check(), Peter Xu, 2017/07/17
[Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add(), Peter Xu, 2017/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] migration: provide migrate_cap_add(),
Juan Quintela <=
[Qemu-devel] [PATCH v2 11/11] migration: check global caps for validity, Peter Xu, 2017/07/17